Add CMake configuration for ESP-IDF component#8
Merged
Conversation
Contributor
|
Hi @omrawaley - thanks for this! As you're a first time contributor, can I just quickly check you've read and agree to the contributor agreement? https://github.com/CubeCoders/Jet/blob/main/CONTRIBUTING.md |
Contributor
Author
|
Yep! Sounds good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, amazing job! This library is incredible and super easy to use after a few tweaks.
In order to use this library as a component with the ESP-IDF, I had to add a small
CMakeLists.txt. With the current branch, I got a build error complaining about it missing since all IDF components need one.After adding this file, I was able to add the Jet library to my
idf_component.ymllike this:I'm not sure if the absence of the
CMakeLists.txtwas intentional so that multiple platforms could be targeted but, in any case, it would be worth adding it somewhere (maybe in a new branch) since the current ESP-IDF component is technically non-functional.Thanks!